[Bug 768687] Rework video orientation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768687

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #11 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Xabier Rodríguez Calvar from comment #10)
> Review of attachment 331253 [details] [review]:
> 
> I was puzzled by this and that's why I set to AUTO, but I can change it back
> 
> static void
> gst_video_flip_init (GstVideoFlip * videoflip)
> {
>   /* AUTO is not valid for active method, this is just to ensure we setup the
>    * method in gst_video_flip_set_method() */
>   videoflip->active_method = GST_VIDEO_ORIENTATION_AUTO;
> }

We have the method and a copy (the active one) of that method. This is to be
able to remember we are in auto mode, and so the get_property() return what the
user have set. The active method cannot be AUTO since it would mean we have no
idea what to do. During negotiation, if there was no tag, we change that into
identity. If there is a tag, we keep the tag. We also need the copy to remember
in the first. So auto here is used as a tempory "invalid" value, to signal that
we are not negotiated.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.