[Bug 768761] wayland: Error check before using cached wl_display

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768761

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #331387|none                        |needs-work
             status|                            |

--- Comment #1 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 331387:
 --> (https://bugzilla.gnome.org/review?bug=768761&attachment=331387)

Overall it looks good, just a couple comments about code-style.

::: gst-libs/gst/vaapi/gstvaapidisplay_wayland.c
@@ +216,3 @@
       priv->display_name, g_display_types);
   if (info) {
+    wl_display_roundtrip(info->native_display);

GStreamer code-style keeps a space before parentheses:
wl_display_roundtrip (info->native_display);

@@ +217,3 @@
   if (info) {
+    wl_display_roundtrip(info->native_display);
+    if (dsp_error = wl_display_get_error(info->native_display))

ditto.

@@ +218,3 @@
+    wl_display_roundtrip(info->native_display);
+    if (dsp_error = wl_display_get_error(info->native_display))
+      GST_ERROR("wayland display error detected: %d\n", dsp_error);

There is no need of \n in log messages such as GST_ERROR

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.