[Bug 752962] v4l2videodec: Add resolution change support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jul 14 02:25:57 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=752962

--- Comment #29 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Some notes about the proposal.

* The EOS handling is wrong

As best on EOS event we can free early the output queue, but we still need to
wait for all buffer to be queued from the capture queue. We could though run
the drain procedure without emitting the stop command. As it is now, it will
drop the capture queue, if I read correctly.

* Wrong value in enum

We subcribe to SOURCE_CHANGE and check for FRAME_SYNC.

* We flush rather then draining

When we handle a resoltion change, it is expected to drain the decoder, to not
loose any of the buffers, right now the code flush.

* A poll function that give you what unblocked

This would reduce the amount of code change that happens all over the place.

* Patch way too big

Split you patch in smaller changes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list