[Bug 768602] EGL_DMA_Buf: Wrong attribute list type for EGL 1.5

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768602

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #331456|none                        |needs-work
             status|                            |

--- Comment #14 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 331456:
 --> (https://bugzilla.gnome.org/review?bug=768602&attachment=331456)

This won't compile with EGL_VERSION_1_5 defined

::: gst-libs/gst/gl/egl/gsteglimage.c
@@ +262,3 @@

+#ifdef EGL_VERSION_1_5
+  if (GST_GL_CHECK_GL_VERSION (context->majorVersion, context->minorVersion,
1, 5)) {

erm, aren't these egl_major and egl_minor now?  Also, don't you want to access
the ctx_egl instance, not the parent class context instance?

::: gst-libs/gst/gl/gstglcontext.h
@@ +74,3 @@

+  gint egl_major;
+  gint egl_minor;

Erm, adding egl versions to the parent class is a bad idea.

This should go in GstGLContextEGL.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.