[Bug 768794] ion: DMA Buf allocator based on ion
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Jul 14 10:55:54 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=768794
Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #331464|none |needs-work
status| |
--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 331464:
--> (https://bugzilla.gnome.org/review?bug=768794&attachment=331464)
Please run gst-indent on those, the coding style if largely wrong. Looks good
in general, but I have few question:
1) How come the heap_mask is hardocded ? What odes 8 means ?
2) Wouldn't it be better to put this allocation into gstreamer-allocator
library, and add support for that allocation in few elements ?
3) Is is possible to explain what one need to enable in a Linux Kernel to use
this allocator ?
4) Having ion.h is probably insufficient to make sure we have ion in our
kernel, how do we figure-out when this allocator should be used ?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list