[Bug 768510] appsrc: handle pushing custom segments

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768510

--- Comment #11 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #7)
> Review of attachment 331151 [details] [review]:

> @@ +1202,2 @@
>        if (!GST_IS_BUFFER (obj)) {
> +        if (!GST_IS_CAPS (obj)) {
> 
> Store the GstSample in the queue, and then use
> gst_sample_get_buffer/caps/segment() here instead

Do we need to queueing all the members as a GstSample? I'd like to suggest that
queueing only SEGMENT/CAPS using GstSample at
gst_app_src_push_sample_internal() method. And queueing buffer without any
modification from previous way... Actually, I tried some ways, but everything
in gst_app_src_push_buffer_full () method is need at that moment of
"push-sample" method/action is called (such as blocking, do timestamp and flow
return).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.