[Bug 756806] message: Add extra information fields to error/warning/info messages

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jul 18 09:04:11 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=756806

--- Comment #16 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
One clarification, though:

End of comment 2:

> @@ +468,3 @@
> + */
> +GstStructure *
> +gst_message_parse_error_details (GstMessage * message)
> 
> Elsewhere we use an out parameter for the return values. Seems a bit inconsistent

Then, end of comment 14:

> > - I wonder if _parse_details() shouldn't return a const GstStructure * that
> > is valid as long as the message is valid, thus avoiding a structure copy
> > when parsing it, and a free.
> 
> Yes!

So I go back to the original, right (plus make it const) ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list