[Bug 768811] decodebin3/playbin3: fix leaks

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jul 18 13:09:33 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=768811

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.9.2

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Nice, thanks!

I've taken the liberty to squash'em a bit, hope you don't mind :)

commit 9834782afa1e5eada76cda985f301562fae1d470
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Thu Jul 14 10:33:38 2016 +0200

    playbin3: fix stream leak

    The stream returned by gst_message_streams_selected_get_stream() is
    reffed.

    https://bugzilla.gnome.org/show_bug.cgi?id=768811

commit 83f30627cd9460157935e7e9603c60a15555967e
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Wed Jul 13 16:16:21 2016 +0200

    decodebin3: fix collection leak

    The collection owned by GstDecodebin3 has to be unreffed when disposing.

    gst_event_new_stream_collection() doesn't consume the collection passed
    to it so no need to give it an extra ref.

    https://bugzilla.gnome.org/show_bug.cgi?id=768811

commit c1db195ba5b24d58158025473a632e3fe979c0cb
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Thu Jul 14 10:34:30 2016 +0200

    decodebin3: fix stream leaks

    MultiQueueSlot owns a ref on the active stream so it should release it
    when being freed.

    DecodebinInputStream owns ref on the active and pending stream so they
    should be dropped when being freed.

    https://bugzilla.gnome.org/show_bug.cgi?id=768811

commit e2263673d1a4178a1ec6e5805f75f2f8fe96fa9a
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Thu Jul 14 14:24:23 2016 +0200

    decodebin3: fix event leaks

    Returning GST_PAD_PROBE_HANDLED means we are taking care of unreffing

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list