[Bug 767712] xvimage: Missing sanity checking for allocation sizes for various video formats

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767712

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.9.2

--- Comment #36 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
I think since we error out now it's probably better to only do so if the memory
is smaller than we (and all other elements) expect, so changed that on top of
your patches.

commit 3273714e0a9d41d86d0013e6d6d4655162ba6da0
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Mon Jul 18 14:20:11 2016 +0100

    xvimagesink: only error out if the allocated memory is too small

    https://bugzilla.gnome.org/show_bug.cgi?id=767712

commit f00bbd2ea543e55c2b38ed80e8493e3119c9eb58
Author: Duncan Palmer <dpalmer at digisoft.tv>
Date:   Mon Jul 18 19:59:23 2016 +1000

    xvimageallocator: const correctness in gst_xvimage_allocator_alloc().

    https://bugzilla.gnome.org/show_bug.cgi?id=767712

commit 4e83e894dfd2bf0e52e826dd42a93f0bed61ab4f
Author: Duncan Palmer <dpalmer at digisoft.tv>
Date:   Thu Jul 7 22:27:15 2016 +1000

    xvimagesink: error out on buffer size sanity check failure.

    If sanity checks on the buffer size allocated by XvShmCreateImage() fail,
    call on g_set_error(), rather than just logging a warning, as this
    failure is fatal.

    Add a sanity check on buffer size when the video format is RGB. This adds
to
    existing checks on various YUV pixel formats.

    https://bugzilla.gnome.org/show_bug.cgi?id=767712

Thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.