[Bug 768989] leaks: update type filter later for unknown types

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768989

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #331817|none                        |needs-work
             status|                            |

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 331817
  --> https://bugzilla.gnome.org/attachment.cgi?id=331817
leaks: update type filter later for unknown types

>@@ -107,6 +116,24 @@ should_handle_object_type (GstLeaksTracer * self, GType object_type)
> 
>+  if (self->unhandled_filter) {
>+    const gchar *type_name;
>+
>+    type_name = g_type_name (object_type);
>+    GST_OBJECT_LOCK (self);
>+    if (g_hash_table_contains (self->unhandled_filter, type_name)) {
        ...
>+    }
>+    GST_OBJECT_UNLOCK (self);
>+  }

The if (self->unhandled_filter) is still unprotected.

Maybe add an atomic int to check if there are pending unhandled types, and if
so take the lock and then do if (self->unhandled_filters) ... ? Or something
like that, dunno :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.