[Bug 768458] vaapiencode: h264: check fps numerator

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768458

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to sreerenj from comment #2)
> (In reply to Víctor Manuel Jáquez Leal from comment #1)
> > Created attachment 330917 [details] [review] [review]
> > RFC: vaapiencode: h264: check fps numerator
> 
> fps checking is already done in gstvaapiencoder, isn't it ?
> so how the code reach here? , if it is reaching here, then there should be
> other failure cases too, for eg do "vaapiencode rate-control=cbr
> bitrate=4096" , it should also break...

Sorry for the delay.

Confirmed: FPS is *not* verified in gstvaapiencoder.

You can reproduce the bug with attachment 325373

gst-launch-1.0 filesrc location= ~/patterns/bug764607.mjpg ! decodebin !
vaapih264enc ! fakesink -v
Setting pipeline to PAUSED ...
libva info: VA-API version 0.39.2
libva info: va_getDriverName() returns 0
libva info: Trying to open /opt/gnome/jh/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_0_39
libva info: va_openDriver() returns 0
Pipeline is PREROLLING ...
Got context from element 'vaapiencodeh264-0': gst.vaapi.Display=context,
gst.vaapi.Display=(GstVaapiDisplay)NULL;
/GstPipeline:pipeline0/GstDecodeBin:decodebin0/GstTypeFindElement:typefind.GstPad:src:
caps = image/jpeg, width=(int)1280, height=(int)720, sof-marker=(int)0
/GstPipeline:pipeline0/GstDecodeBin:decodebin0/GstVaapiDecode_jpeg:vaapidecode_jpeg0.GstPad:sink:
caps = image/jpeg, width=(int)1280, height=(int)720, sof-marker=(int)0
Redistribute latency...
/GstPipeline:pipeline0/GstDecodeBin:decodebin0/GstVaapiDecode_jpeg:vaapidecode_jpeg0.GstPad:src:
caps = video/x-raw(memory:VASurface), format=(string)NV12, width=(int)1280,
height=(int)720, interlace-mode=(string)progressive,
pixel-aspect-ratio=(fraction)1/1, framerate=(fraction)0/1
Floating point exception

But the patch is not correct. We should use gst_util_uint64_scale().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.