[Bug 769041] New: qtmux: Downscaling time value loses precision

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769041

            Bug ID: 769041
           Summary: qtmux: Downscaling time value loses precision
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: glippitsch at toolsonair.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 331889
  --> https://bugzilla.gnome.org/attachment.cgi?id=331889&action=edit
[PATCH] Remove down scaling of time value, since it loses precision

In qtmux, the frame rate nominator is divided by 10 if it does not fit into a
range from 1000 to 10000 until it fits. But this division is wrong, as it
throws away precision in time base representation. For example, a frame rate of
30000/1001 (very common NTSC frame rate) cannot be represented by a smaller
time base. Currently, in this case the frame rate nominator would be scaled to
3000, and a wrong time base is thus written to the qt file.

The attached patch removes time value division. The resulting files where
tested in Final Cut X, which now detects frame rate correctly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.