[Bug 768458] vaapiencode: h264: check fps numerator

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768458

--- Comment #5 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #4)
> @sree,
> 
> Another question, is correct
> 
>      encoder->cts_offset = GST_SECOND * GST_VAAPI_ENCODER_FPS_D (encoder) /
>          GST_VAAPI_ENCODER_FPS_N (encoder);
> 
> ???
> 
> cts_offset is used to calculate frame->pts (composition timestamp for
> presentation timestamp)
> 
> But D/N doesn't look right to me. It should be N/D, but I would like your
> confirmation.
> 
> This code is also used in h265 encoding.

This code block is only adding an extra frame duration/delay if there is b
frames included in the stream. one frame duration = D/N , missing something ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.