[Bug 756806] message: Add extra information fields to error/warning/info messages

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756806

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #331985|none                        |reviewed
             status|                            |

--- Comment #29 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 331985:
 --> (https://bugzilla.gnome.org/review?bug=756806&attachment=331985)

::: gst/gstelement.c
@@ +3482,3 @@
+
+GstStructure *
+gst_message_details_new (const char *name, ...)

If you put it into gstelement.c, make it gst_element_message_details_new() :)

@@ +3486,3 @@
+  GstStructure *structure;
+  va_list varargs;
+

if (name == NULL)
  return NULL;

maybe?

@@ +3488,3 @@
+
+  va_start (varargs, name);
+  structure = gst_structure_new_valist ("details", name, varargs);

No quark for the string?

::: gst/gstmessage.c
@@ +628,3 @@
+  g_value_init (&v, GST_TYPE_STRUCTURE);
+  g_value_take_boxed (&v, details);
+  gst_structure_id_take_value (GST_MESSAGE_STRUCTURE (message), details_quark,

Just inline that into the constructors for now

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.