[Bug 756806] message: Add extra information fields to error/warning/info messages

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756806

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #331991|none                        |accepted-commit_now
             status|                            |

--- Comment #32 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 331991:
 --> (https://bugzilla.gnome.org/review?bug=756806&attachment=331991)

Good to go IMHO, just see below and feel free to fix or not before merging

::: gst/gstelement.c
@@ +3491,3 @@
+
+  va_start (varargs, name);
+  structure = gst_structure_new_valist ("details", name, varargs);

Still no quark but ok :)

::: gst/gstmessage.c
@@ +512,3 @@
   message = gst_message_new_custom (GST_MESSAGE_WARNING, src, structure);
+  if (details) {
+    GValue v = { 0 };

G_VALUE_INIT btw

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.