[Bug 768995] New API: StreamGroupDone event

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768995

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #331823|none                        |reviewed
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 331823:
 --> (https://bugzilla.gnome.org/review?bug=768995&attachment=331823)

Generally seems good to me

::: plugins/elements/gstinputselector.c
@@ +485,3 @@
+       * running time, as this pad just switched to EOS and
+       * may enable others to progress */
+      GST_INPUT_SELECTOR_BROADCAST (self);

This seems like a separate bugfix that can go into another commit? What does it
fix? :)

@@ +638,3 @@
+      selpad->group_done = TRUE;
+      if (sel->sync_streams && active_sinkpad == pad)
+        GST_INPUT_SELECTOR_BROADCAST (sel);

It's usually a good idea to take the lock before you change variables and
broadcast/signal for those variable changes

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.