[Bug 769080] decodebin3: fix collection refcounting

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769080

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |bilboed at bilboed.com
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.9.2

--- Comment #3 from Edward Hervey <bilboed at bilboed.com> ---
commit c1f37edfd9e5939de78aa442afd5dec03e966193
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Fri Jul 22 14:40:25 2016 +0200

    playbin3: fix collection leak

    The collection referenced owned by playbin3 was not released when it was
    destroyed.

    https://bugzilla.gnome.org/show_bug.cgi?id=769080

commit 2c0a4d20d4c75bf2cfdc03d18321241221421561
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Fri Jul 22 14:35:17 2016 +0200

    decodebin3: fix collection refcounting

    My collection leak fix 83f30627cd9460157935e7e9603c60a15555967e
    introduced a crash in this scenario: audiotestsrc ! decodebin3 ! fakesink

    The reference handling of collection in decodebin3 wasn't very clear and
    my attempt to fix the leak introduced a regression where we went one
    reference short in some other scenarios.

    Fixing this by:
    - Giving a strong reference to DecodebinInput making things clearer
    - Fixing get_merged_collection() which was sometimes returning an
      existing reference and sometimes a new one.

    https://bugzilla.gnome.org/show_bug.cgi?id=769080

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.