[Bug 768326] Building GStreamer for Android fails on Windows (new since 1.8.2)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768326

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Andy Devar from comment #11)
> Created attachment 331629 [details] [review]
> Patch for original gstreamer-1.0.mk in gstreamer-1.0-android-armv7-1.8.2
> 
> >
> > Or should the content of the SED variable maybe contain the " on Windows?
> >
> This doesn't work - probably because some other script included by
> gstreamer-1.0.mk requires that $(SED) does not contain the quotes.

Which other scripts and why/how do they require that?

> Therefore, I have created a new variable named SED_LOCAL, which contains the
> quoted sed path on windows. On other OSes, it contains the non-quoted sed
> path - I assume that on other OSes those should must not be present. Someone
> should check that before committing my changes.
> 
> I've then replaced all occurrences of $(SED) in gstreamer-1.0.mk  with
> $(SED_LOCAL).

Seems like a reasonable approach if there's nothing else we can do :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.