[Bug 765807] dvdlpcmdec: rewrite with GstAudioDecoder and add new format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765807

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Michael Olbrich from comment #13)
> (In reply to Sebastian Dröge (slomo) from comment #11)
> > Review of attachment 330069 [details] [review] [review]:
> > 
> > And even in a lossy transport like RTP, how would you end up with incomplete
> > packets? At the UDP level this should've already been dropped if the UDP
> > packet was incomplete, and the RTP depayloader should detect if there are
> > missing packets and handle that somehow.
> 
> The pipeline here is basically rtpmp2tdepay -> tsdemux -> dvdlpcmdec. I
> don't think rtpmp2tdepay can handle this. Maybe tsdemux can, but I'm not
> sure it should: That would just mean we loose more data. This way we play as
> much as possible. But I should add a GST_BUFFER_FLAG_DISCONT to the next
> buffer, right?

Yes, seems ok then

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.