[Bug 765314] player: Add way to override HTTP (+RTSP, etc) user agent

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765314

--- Comment #10 from Guillaume Desmottes <gdesmott at gnome.org> ---
(In reply to Sebastian Dröge (slomo) from comment #9)
> Review of attachment 332008 [details] [review]:
> 
> ::: gst-libs/gst/player/gstplayer.c
> @@ +2540,3 @@
> +  if (user_agent) {
> +    if (g_object_class_find_property (G_OBJECT_GET_CLASS (source),
> +            "user-agent")) {
> 
> You should check if it actually takes a string :)

Indeed. Done.

> @@ +4141,3 @@
> + *
> + * Returns: %TRUE when the configuration could be set.
> + * Since 1.12
> 
> Since: with colon, and this seems like it will go into 1.10 ;)

ooops; fixed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.