[Bug 767011] rawparse: new rawaudioparse and rawvideoparse element which deprecate audioparse, unalignedaudioparse, and videoparse

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767011

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330608|none                        |needs-work
             status|                            |

--- Comment #32 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330608:
 --> (https://bugzilla.gnome.org/review?bug=767011&attachment=330608)

rawvideoparse is still missing the frame-size property (there could be more
padding at the very end of a frame), otherwise this looks good to go to me.

Main reason why we can't remove the old parsers at this point is the property
name changes, right? Apart from that it should be compatible?

::: gst/rawparse/gstrawaudioparse.h
@@ +89,3 @@
+   * for reordering channel data in outgoing buffers if necessary.
+   */
+  GstAudioChannelPosition *valid_channel_positions;

The two arrays here can just be statically allocated [64] arrays. Less memory
to keep track of

::: gst/rawparse/gstrawvideoparse.c
@@ +940,3 @@
+   * from here */
+  while (TRUE) {
+    GstVideoMeta *videometa = gst_buffer_get_video_meta (out_data);

while ((videometa = gst_buffer_get_video_meta (out_data)) { ... }

might be more beautiful... but not so important :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.