[Bug 768458] vaapiencode: use gst_util_uint64_scale() and check fps numerator

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768458

--- Comment #9 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #7)
> Created attachment 331968 [details] [review]
> vaapiencode: h264,h265: validate fps numerator
> 
> Validate that fps numerator is non-zero so it can be used to calculate
> the duration of the B frame.
> 
> Also it gst_util_uint64_scale() is used instead of normal arithmetic in
> order to aviod overflows, underflows and loss of precision.

I am fine with the patch, But wondering whether we need this offset addition.

x264 enc with 1 bframe: pts of output frames (why 1000.xxx.xx??? )
pts: 1000:00:00.000000000
pts: 1000:00:00.066666666
pts: 1000:00:00.033333333

vaapih264enc with 1 bframe: pts of output frames:
pts: 0:00:00.033333333
pts: 0:00:00.099999999
pts: 0:00:00.066666666

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.