[Bug 766419] videotimecode: Added support for SMPTE time code metadata

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766419

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328829|none                        |needs-work
             status|                            |

--- Comment #23 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 328829:
 --> (https://bugzilla.gnome.org/review?bug=766419&attachment=328829)

::: gst-libs/gst/video/gstvideometa.c
@@ +653,2 @@
   return meta->upload (meta, texture_id);
+

Useless newline

@@ +928,3 @@
+GstVideoTimeCodeMeta *
+gst_buffer_add_video_time_code_meta (GstBuffer * buffer, GstVideoTimeCode *
tc)
+{

g_return_val_if_fail()

@@ +941,3 @@
+  GstVideoTimeCodeMeta *meta;
+
+  g_return_val_if_fail (GST_IS_BUFFER (buffer), NULL);

Check for valid timecode

::: gst-libs/gst/video/gstvideometa.h
@@ +300,3 @@
+ * GstVideoTimeCodeMeta:
+ * @meta: parent #GstMeta
+ * @roi_type: GQuark describing the semantic of the Roi (f.i. a face, a
pedestrian)

Copy&paste mistake (also "f.i."?!)

@@ +304,3 @@
+ * @tc: the GstVideoTimeCode to attach
+ *
+ * Extra buffer metadata describing the GstVideoTimeCode of the frame

Since: 1.10 in the docs everywhere

@@ +320,3 @@
+       
((GstVideoTimeCodeMeta*)gst_buffer_get_meta((b),GST_VIDEO_TIME_CODE_META_API_TYPE))
+GstVideoTimeCodeMeta *gst_buffer_add_video_time_code_meta    (GstBuffer   *
buffer,
+                                                                              
GstVideoTimeCode * tc);

While we're at it, indentation is weird.

@@ +323,3 @@
+
+GstVideoTimeCodeMeta *
+gst_buffer_add_video_time_code_meta_full (GstBuffer * buffer, guint hours,
guint minutes, guint seconds, guint frames, guint field_count, guint fps_n,
guint fps_d, GDateTime * latest_daily_jam, GstVideoTimeCodeFlags flags);

Same thing with the order as with gst_video_time_code_new()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.