[Bug 766419] videotimecode: Added support for SMPTE time code metadata

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766419

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330663|none                        |needs-work
             status|                            |

--- Comment #29 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330663:
 --> (https://bugzilla.gnome.org/review?bug=766419&attachment=330663)

Maybe squash together with the other patch

::: gst/timecodestamper/gsttimecodestamper.c
@@ +115,3 @@
+          FALSE,
+          (GParamFlags) (G_PARAM_CONSTRUCT | G_PARAM_READWRITE |
+              G_PARAM_STATIC_STRINGS)));

Same as with the other patch

@@ +168,3 @@
+      break;
+    case PROP_SOURCE_CLOCK:
+      timecodestamper->source_clock = g_value_get_object (value);

dup_object() and unref any already existing one. And unref in finalize

@@ +203,3 @@
+  if (timecodestamper->drop_frame && timecodestamper->vinfo.fps_d == 1001 &&
+      (timecodestamper->vinfo.fps_n == 2997 ||
+          timecodestamper->vinfo.fps_d == 5994))

30000 and 60000

@@ +208,3 @@
+  else
+    timecodestamper->current_tc->config.flags &=
+        !GST_VIDEO_TIME_CODE_FLAGS_DROP_FRAME;

~ instead of !

@@ +336,3 @@
+    GstClockTime timecode_time;
+
+    g_assert_nonnull (timecodestamper->current_tc);

It is by construction

@@ +341,3 @@
+    ref_time =
+        gst_segment_to_stream_time (&vfilter->segment, GST_FORMAT_TIME,
+        buffer->pts);

Times could all be invalid

@@ +350,3 @@
+          ") has drifted more than one second from stream time %"
+          GST_TIME_FORMAT, tc_str, GST_TIME_ARGS (timecode_time),
+          GST_TIME_ARGS (ref_time));

And then? Shouldn't we resync something? Otherwise this will complain for every
following frame :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.