[Bug 768160] qtplugins: How to implement qmlglsrc.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768160

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332188|none                        |needs-work
             status|                            |

--- Comment #21 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 332188:
 --> (https://bugzilla.gnome.org/review?bug=768160&attachment=332188)

Just some style fixes.

::: gst-libs/gst/gl/x11/gstglwindow_x11.c
@@ +390,3 @@
   GstGLWindowX11 *window_x11 = data;
   GstGLWindow *window = GST_GL_WINDOW (window_x11);
+  guint width, height;

Move inside the gst_gl_window_is_running block.

@@ +418,3 @@
+    gst_gl_window_get_surface_dimensions (window, &width, &height);
+    if (attr.width != width || attr.height != height) {
+      gst_gl_window_resize (window, attr.width, attr.height);

Use gst_gl_window_queue_resize() here.

@@ +426,1 @@
         gst_gl_window_get_surface_dimensions (window, &width, &height);

duplicated get_surface_dimensions()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.