[Bug 769215] aacparse: Need to relax the detection of ADTS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769215

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net,
                   |                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
This is the history of it:

commit 2ad1f20e7b430985091ea2f4e8ba753f9e908c46
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Tue Jan 14 09:43:33 2014 +0000

    Revert "aacparse: relax the detection of ADTS"

    This was pushed by mistake along with the V4L2 fix.

    This reverts commit 8eb4b032bef444397c4d211f2095c173ba114187.

commit 8eb4b032bef444397c4d211f2095c173ba114187
Author: Akihiro Tsukada <atsukada at users.sourceforge.net>
Date:   Wed Feb 27 01:45:52 2013 +0900

    aacparse: relax the detection of ADTS

    According to ISO/IEC 13818-7, "channel_config" field in ADTS header
    may have value of 0, as in the case of frame with PCE.
    gst_aac_parse_detect_streams() returned FALSE for those frames
    and discarded them.


Vincent, why did you revert it again and where does the original patch come
from?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.