[Bug 769248] plugins: Update buffer pool size with new va allocator's image

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jul 29 09:44:39 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=769248

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332336|none                        |needs-work
             status|                            |

--- Comment #5 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 332336:
 --> (https://bugzilla.gnome.org/review?bug=769248&attachment=332336)

::: gst/vaapi/gstvaapipluginbase.c
@@ +836,3 @@
+    /* Update video size with allocator's image size */
+    size = GST_VIDEO_INFO_SIZE (&GST_VAAPI_VIDEO_ALLOCATOR_CAST
+        (plugin->srcpad_allocator)->image_info);

That looks better!

But, now we should remove the previous size calculations in the function, since
they will be overiwritten by this one.

And I would add a function in gstvideomemory.{c,h} like gboolean
gst_vaapi_video_allocator_get_image_size(GstAllocator * allocator, gsize *
size);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list