[Bug 765052] tracer: add (mini) object leak tracer

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jun 1 10:36:44 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=765052

--- Comment #55 from Guillaume Desmottes <gdesmott at gnome.org> ---
Review of attachment 328808:
 --> (https://bugzilla.gnome.org/review?bug=765052&attachment=328808)

::: plugins/tracers/Makefile.am
@@ +23,3 @@
   gststats.c \
+  gsttracers.c \
+  gstleaks.c

done.

@@ +38,3 @@
   gstrusage.h \
+  gststats.h \
+  gstlatency.h

done.

::: plugins/tracers/gstleaks.c
@@ +70,3 @@
+
+    self->filter = g_list_prepend (self->filter, GSIZE_TO_POINTER (type));
+  }

Switched to a Garray<GType> as suggested.

@@ +98,3 @@
+    if (GST_IS_MINI_OBJECT_TYPE (object, type))
+      return TRUE;
+  }

good idea; done.

@@ +130,3 @@
+
+  if (G_IS_OBJECT (object))
+    g_object_weak_ref (G_OBJECT (object), object_weak_cb, self);

done.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list