[Bug 765052] tracer: add (mini) object leak tracer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765052

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328873|none                        |needs-work
             status|                            |

--- Comment #57 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
Review of attachment 328873:
 --> (https://bugzilla.gnome.org/review?bug=765052&attachment=328873)

::: plugins/tracers/Makefile.am
@@ +24,2 @@
   gststats.c \
+  gsttracers.c

almost, I ignored $(), so that '$(LOG...)' is sorted as 'gstlog...'

::: plugins/tracers/gstleaks.c
@@ +26,3 @@
+ * alive when program is exiting and raising a warning.
+ * The type of objects tracked can be filtered using the parameters of the
+ * tracer, for example: GST_TRACERS="leaks(GstEvent,GstMessage)

nit: missing " at the end of line

@@ +132,3 @@
+handle_object_created (GstLeaksTracer * self, gpointer object, GType type)
+{
+  if (!should_handle_object (self, object))

just pass the GType here as well, then you don't need to determine it from the
object again.

@@ +152,3 @@
+  GstLeaksTracer *self = GST_LEAKS_TRACER (tracer);
+
+  handle_object_created (self, object, GST_MINI_OBJECT_TYPE (object));

maybe inline the function to avoid the if G_IS_OBJECT check. it is not
duplication a lot of code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.