[Bug 763026] dc1394: port to 1.X

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763026

Joan Pau <joanpau.beltran at socib.cat> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327650|reviewed                    |none
             status|                            |
 Attachment #327650|0                           |1
        is obsolete|                            |

--- Comment #10 from Joan Pau <joanpau.beltran at socib.cat> ---
Created attachment 328900
  --> https://bugzilla.gnome.org/attachment.cgi?id=328900&action=edit
dc1394src: port to 1.X (with so far proposed modifications)

This is a modified version of the initial patch
with the modifications discussed so far, namely:

  - Replace the camera number integer property to indentify the camera
    by a pair of GUID and unit properties (string and integer).
    Operate on the first camera available if GUID is null (default).
    Match any camera unit number if unit is -1.

  - Redefine the ISO speed property as enum type (instead of integer).

  - Map DC1394_COLOR_CODING_YUV444 to GST_VIDEO_FORMAT_IYU2 introduced
    in commit: abb88801e79bde97523c0ad4dba30a463b5d922d.

  - Replace `GstElement` state change function by start` and stop functions
    from `GstBaseSrc`.

  - Stop the camera in set caps method before setting new caps and
    restarting again (it has no effect if the camera is not started).

Hence, the only 3 points left to discuss from the initial proposal are:

  - The buffer creation method (copy instead of wrapping)

  - The buffer timestamping (delegated to the GstBaseSrc parent class I think)

  - The replacement of prefix `gst_dc1394` by `gst_dc1394_src`
    (it only affects the code,the name of the element is already `dc1394src`)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.