[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328916|none                        |reviewed
             status|                            |

--- Comment #79 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 328916:
 --> (https://bugzilla.gnome.org/review?bug=766236&attachment=328916)

::: ext/openjpeg/gstopenjpegenc.c
@@ +689,3 @@
     g_return_val_if_reached (FALSE);

+  if (sampling) {

When could we ever have no sampling?

::: gst/videoparsers/gstjpeg2000sampling.h
@@ +50,3 @@
+#define GST_RTP_J2K_RGBA      "RGBA"
+#define GST_RTP_J2K_BGRA      "BGRA"
+#define GST_RTP_J2K_YBRA         "YCbCrA"

This should probably be YCbCrA-4:4:4:4. There is also 4:4:2:0
(GST_VIDEO_FORMAT_A420)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.