[Bug 766618] mpegtsmux, high overhead for a small aac bitrate

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766618

--- Comment #4 from Vincent Génieux <vincent.genieux at startigen.fr> ---

Ok, I can store a GstAdapter into MpegTsPadData::prepare_data, and then use it
into mpegtsmux_prepare_aac.


This algorithm comes from libav :
libav/libavformat/mpegtsenc.c:1143

1) In libav/libavformat/mpegtsenc.c:1143, the latency is taken into accound via
a max_delay parameter :
"""
    if (ts_st->payload_size + size > ts->pes_payload_size ||
        (dts != AV_NOPTS_VALUE && ts_st->payload_dts != AV_NOPTS_VALUE &&
         av_compare_ts(dts - ts_st->payload_dts, st->time_base,
                       s->max_delay, AV_TIME_BASE_Q) >= 0)) {
"""

-> may be we could implement the same solution in mpegtsmux ? (e.g: add a
"max-delay" property).


2) libav does not only aggregates AAC frames, but frames for all audio media,
do you think mpegtsmux should do the same ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.