[Bug 608148] tsdemux: Better handle PCR<=>PTS conversion (big difference, latency, ...)

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 3 12:25:57 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=608148

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329023|none                        |needs-work
             status|                            |

--- Comment #23 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 329023:
 --> (https://bugzilla.gnome.org/review?bug=608148&attachment=329023)

::: gst/mpegtsdemux/mpegtspacketizer.c
@@ +2190,3 @@
   pcrtable = get_pcr_table (packetizer, pcr_pid);

+  if (!GST_CLOCK_TIME_IS_VALID (pcrtable->base_time) && pcr_pid == 0x1fff &&

Using the input buffer time is a good idea to solve this issue.

But this will fail if there's a discontinuity in the input stream. We should
set the base_time to GST_CLOCK_TIME_NONE again in
mpegts_packetizer_{flush|clear} for this to work properly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list