[Bug 631673] add "redirect" message to core

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=631673

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329048:
 --> (https://bugzilla.gnome.org/review?bug=631673&attachment=329048)

Generally looks good to me but

::: gst/gstmessage.c
@@ +2529,3 @@
+ * gst_message_new_redirect:
+ * @src: The #GstObject whose property changed (may or may not be a
#GstElement)
+ * @location: (transfer none) (allow-none) location string for the new entry

I don't think this should be allow-none really :) What's the point of a
redirect without a location?

@@ +2542,3 @@
+ * when the redirect message is created, with the given location, tag_list,
+ * entry_struct arguments. Use gst_message_add_redirect_entry() to add more
+ * entries.

Maybe should specify that, given no other information to decide, they should be
preferred in the order they are added? Or the same preference?

@@ +2598,3 @@
+ * gst_message_add_redirect_entry:
+ * @message: a #GstMessage of type %GST_MESSAGE_REDIRECT
+ * @location: (transfer none) (allow-none) location string for the new entry

And here. Should IMHO be a g_return_val_if_fail() in both cases too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.