[Bug 766596] vaapipostproc: some video info is dropped on src caps.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766596

--- Comment #11 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Hyunjun Ko from comment #10)
> (In reply to Víctor Manuel Jáquez Leal from comment #9)
> > (In reply to Víctor Manuel Jáquez Leal from comment #4)
> > > 
> > > @@ +646,3 @@
> > >    if (!_fixate_frame_rate (postproc, vinfo, structure))
> > >      goto fixate_failed;
> > > +  if (!_set_colorimetry (postproc, format, structure))
> > > 
> > > We also have to check if the processed feature is
> > > GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY. Other features, like GLTextureUpload
> > > or VASurface don't need that information in the caps.
> > 
> > What about this check?
> 
> Oh, I thought that this patch would be ignored once vaapidecoder drops these
> attributes.
> This is necessary in case that caps feature is
> GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY?

Noup, because you patch extracts the colorimetry  value from

gst_video_info_set_format (&vinfo, format, width, height);

Where format is the output format.

And that is true only when the caps feature is
GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.