[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329263|none                        |committed
             status|                            |

--- Comment #116 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329263:
 --> (https://bugzilla.gnome.org/review?bug=766236&attachment=329263)

::: gst/videoparsers/gstjpeg2000parse.c
@@ +354,3 @@
+    if (sampling) {
+      GstStructure *src_caps_struct = gst_caps_get_structure (src_caps, 0);
+      gst_structure_set (src_caps_struct, "sampling", G_TYPE_STRING, sampling,

Changed this to gst_caps_set_simple() for consistency with the code below

@@ +391,3 @@
+      goto beach;
+
+    gst_buffer_unmap (frame->buffer, &map);

You leak current_caps here (fixed that while merging).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.