[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

--- Comment #129 from boxerab at gmail.com <boxerab at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #128)
> It is with JP2, but not otherwise AFAIU. Aaron?

(In reply to Sebastian Dröge (slomo) from comment #123)
> Review of attachment 329292 [details] [review]:
> 
> Almost good to go, thanks :)
> 
> ::: gst/rtp/gstrtpj2kdepay.c
> @@ +208,3 @@
> +      "fields", G_TYPE_INT, 1,
> +      "colorspace", G_TYPE_STRING, colorspace,
> +      "sampling", G_TYPE_STRING, sampling, NULL);
> 
> We could also take width and height from the input caps and copy them  over,
> if they exist
> 
> ::: gst/rtp/gstrtpj2kpay.c
> @@ -150,3 @@
> -  if (gst_structure_get_int (caps_structure, "width", &width)) {
> -    pay->width = width;
> -  }
> 
> And here the intention probably was to put these into the caps. They are
> optional, so if they exist we put them into the caps and otherwise not :)
> Seems better to do that instead of removing this code
> 
> @@ +177,3 @@
>    gboolean multi_tile_part;
>    gboolean bitstream;
> +  guint32 next_sot;
> 
> Why?
> 
> ::: gst/rtp/gstrtpj2kpay.h
> @@ -43,3 @@
> -
> -  gint height;
> -  gint width;
> 
> Storing the struct is of course not necessary anymore

Thanks, working on this now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.