[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

--- Comment #134 from boxerab at gmail.com <boxerab at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #125)
> Review of attachment 329292 [details] [review]:
> 
> ::: gst/rtp/gstrtpj2kdepay.c
> @@ +57,3 @@
>      GST_STATIC_CAPS ("application/x-rtp, "
> +        "media = (string) \"video\", " "clock-rate = (int) 90000, "
> +        GST_RTP_J2K_SAMPLING_LIST "," "encoding-name = (string)
> \"JPEG2000\"")
> 
> We should keep the field optional here for backwards compat reasons... and
> fall back to YUV (with subsampling as parsed from the stream)

Good idea.(In reply to Sebastian Dröge (slomo) from comment #124)
> Review of attachment 329292 [details] [review]:
> 
> ::: gst/rtp/gstrtpj2kdepay.c
> @@ +208,3 @@
> +      "fields", G_TYPE_INT, 1,
> +      "colorspace", G_TYPE_STRING, colorspace,
> +      "sampling", G_TYPE_STRING, sampling, NULL);
> 
> And should probably also make use of the sampling field in the decoder... to
> distinguish between BGR and RGB for example.

Btw, a JP2 stream can be parsed to determine the channel order.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.