[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329339|none                        |needs-work
             status|                            |

--- Comment #138 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329339:
 --> (https://bugzilla.gnome.org/review?bug=766236&attachment=329339)

::: gst/rtp/gstrtpj2kdepay.c
@@ +205,3 @@
+    if (!colorspace) {
+      res = FALSE;
+      goto cleanup;

This means that we need to require either of the two here, but the old code
just assumed sYUV if nothing was given. We should probably keep this.

And if there is no sampling in the caps, we should warn loudly so that people
are not too confused if the decoded frames look funny. In 2.0 all this should
go away then :)

@@ +213,3 @@
+      sampling = GST_RTP_J2K_RGB;
+    } else {
+      sampling = GST_RTP_J2K_YBR444;

I think we shouldn't set an arbitrary sampling, but rather no sampling at all
(and let a parser figure that out after the depayloader if needed)

::: gst/rtp/gstrtpj2kpay.c
@@ +154,2 @@
+  if (gst_structure_get_int (caps_structure, "width", &width)) {
+    gst_caps_set_simple (caps, "width", G_TYPE_INT, width, NULL);

You should provide these to gst_rtp_base_payload_set_outcaps(). What you do now
is to override the values from the input / sinkpad caps

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.