[Bug 766064] basesink: deadlock waiting prerolling while pipeline goes to NULL state

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jun 8 08:18:54 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=766064

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329337|none                        |reviewed
             status|                            |

--- Comment #20 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329337:
 --> (https://bugzilla.gnome.org/review?bug=766064&attachment=329337)

This will need a closer look, in any case thanks for the testcase :) I can't
see anything obviously wrong in it, that is supposed to work

::: gst/gstbin.c
@@ +1146,3 @@
+      GST_DEBUG_OBJECT (parent, "Set as sink");
+      GST_OBJECT_FLAG_SET (parent, GST_ELEMENT_FLAG_SINK);
+      parent = GST_OBJECT_PARENT (parent);

This seems racy, both the setting of the flags and the getting of the parent
elements

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list