[Bug 763026] dc1394: port to 1.X

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763026

--- Comment #15 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Great, thanks. There are no side-effects from renaming and such.

Could I ask you to fix up some minor coding style issues in the first commit?

1) install GNU indent and run gst-indent
(https://cgit.freedesktop.org/gstreamer/gstreamer/tree/tools/gst-indent) on the
.c file (just the .c file not the header file). If that's a problem I can
re-indent it for you.

In _build_caps() you might want to split the variable declarations like this to
avoid the indenter doing weird-looking things:

  GValue format = { 0 };
  GValue formats = { 0 };
  GValue width = { 0 };
  GValue widths = { 0 };
  GValue height = { 0 };
  GValue heights = { 0 };
  GValue framerate = { 0 };
  GValue framerates = { 0 };

2) convert C++ style comments (// hello) to C-style comments (/* hello */)

3) don't use C99 style struct initialisers like = { .num = 7, .foo = { xyz }}

Thanks for your patience ! :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.