[Bug 766803] h264parse: add support for config-interval=-1 to re-send SPS/PPS on I/IDR frames

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766803

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329458|none                        |reviewed
             status|                            |

--- Comment #19 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 329458
  --> https://bugzilla.gnome.org/attachment.cgi?id=329458
h264parse: refactored handling of SPS/PPS when pushing frames

Here you have moved the

  h264parse->last_report = new_ts;

from the inner loop during the refactoring, and are now doing it
unconditionally.

Someone needs to investigate if it matters or not.

I think it's a bit suspicious, I think we might be resetting the timer/counter
even if we didn't send anything yet.

Perhaps it'd be better to make the new function return a boolean if it sent out
stuff, and only reset the last_report time then?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.