[Bug 766803] h264parse: add support for config-interval=-1 to re-send SPS/PPS on I/IDR frames

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766803

--- Comment #21 from Mats Lindestam <mats.lindestam at axis.com> ---
(In reply to Tim-Philipp Müller from comment #19)
> Comment on attachment 329458 [details] [review]
> h264parse: refactored handling of SPS/PPS when pushing frames
> 
> Here you have moved the
> 
>   h264parse->last_report = new_ts;
> 
> from the inner loop during the refactoring, and are now doing it
> unconditionally.
> 
> Someone needs to investigate if it matters or not.
> 
> I think it's a bit suspicious, I think we might be resetting the
> timer/counter even if we didn't send anything yet.
> 
> Perhaps it'd be better to make the new function return a boolean if it sent
> out stuff, and only reset the last_report time then?

You could add new_ts as an function parameter and set it as it was done before?
I think I had it like that in an earlier version of the code. Don't know why I
changed my mind.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.