[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329519|none                        |needs-work
             status|                            |

--- Comment #153 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329519:
 --> (https://bugzilla.gnome.org/review?bug=766236&attachment=329519)

::: gst/videoparsers/gstjpeg2000parse.c
@@ +301,3 @@
+        GST_WARNING_OBJECT (jpeg2000parse,
+            "Sink caps sub-sampling %d,%d for channel %d does not match stream
sub-sampling %d,%d",
+            dx_caps, dy_caps, compno, dx[compno], dy[compno]);

And in this case we should take the colorspace extracted from the sampling, and
the subsampling we read from the stream :) That is, set the parsed_sampling
variable accordingly so it is used below for the caps

@@ +362,3 @@
+  gst_caps_set_simple (src_caps, "colorspace", G_TYPE_STRING, colorspace,
NULL);
+  gst_caps_set_simple (src_caps, "sampling", G_TYPE_STRING, source_sampling,
+      NULL);

If we always set them, it can be in the same gst_caps_new_simple() call above

::: gst/videoparsers/gstjpeg2000parse.h
@@ +60,3 @@
+gboolean gst_jpeg2000_parse_is_mono (const gchar * sampling);
+void gst_jpeg2000_parse_get_subsampling (const gchar * sampling, guint8 * dx,
+    guint8 * dy);

Why are they public, could just be static, no?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.