[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 10 10:15:44 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=766236

--- Comment #157 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to boxerab at gmail.com from comment #156)
> (In reply to Sebastian Dröge (slomo) from comment #155)
> > Review of attachment 329542 [details] [review] [review]:
> > 
> > ::: gst/rtp/gstrtpj2kdepay.c
> > @@ +227,2 @@
> > +  if (outcaps)
> > +    gst_caps_unref (outcaps);
> > 
> > There seems to be no case when outcaps could be NULL
> 
> Yes, that is a relic from an older change. You can simply remove that null
> check.

That's what I did when merging, also other unrelated code style changes and
some other unneeded things

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list