[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329550|none                        |needs-work
             status|                            |

--- Comment #160 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329550:
 --> (https://bugzilla.gnome.org/review?bug=766236&attachment=329550)

::: gst/videoparsers/gstjpeg2000parse.c
@@ +29,3 @@
+/* convenience methods */
+static gboolean gst_jpeg2000_parse_is_rgb (const gchar * sampling);
+//static gboolean gst_jpeg2000_parse_is_yuv (const gchar * sampling);

No C99/C++ comments please :)

@@ +317,3 @@
+        else
+          colorspace = "sYUV";
+        sink_sampling = NULL;

We might have no colorspace field in the caps, only a (wrong) sampling field.
Below we would only set parsed_sampling if colorspace is given, so would
potentially end up with none

@@ -342,3 @@
-set_caps:
-
-  if (dimensions_changed || subsampling_changed) {

We should only set caps if none were set before or they changed. You now set
caps on every single frame, which is a performance problem

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.