[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

--- Comment #162 from boxerab at gmail.com <boxerab at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #160)
> Review of attachment 329550 [details] [review]:
> 
> ::: gst/videoparsers/gstjpeg2000parse.c
> @@ +29,3 @@
> +/* convenience methods */
> +static gboolean gst_jpeg2000_parse_is_rgb (const gchar * sampling);
> +//static gboolean gst_jpeg2000_parse_is_yuv (const gchar * sampling);
> 
> No C99/C++ comments please :)
> 
> @@ +317,3 @@
> +        else
> +          colorspace = "sYUV";
> +        sink_sampling = NULL;
> 
> We might have no colorspace field in the caps, only a (wrong) sampling
> field. Below we would only set parsed_sampling if colorspace is given, so
> would potentially end up with none

Yes. If the subsampling for the sampling field is wrong, I still assume that
the colorspace information in the field is correct, so I set the colorspace
accordingly. Are you saying that if the subsampling is wrong in the sampling
field, that the colorspace information is also suspect?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.