[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329564|none                        |reviewed
             status|                            |

--- Comment #168 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329564:
 --> (https://bugzilla.gnome.org/review?bug=766236&attachment=329564)

Almost there :)

::: gst/videoparsers/gstjpeg2000parse.c
@@ +141,3 @@

+  jpeg2000parse->sampling = "";
+  jpeg2000parse->colorspace = "";

NULL seems like a better choice

@@ +326,3 @@
+          sampling_colorspace = "sRGB";
+        else if (gst_jpeg2000_parse_is_yuv (sink_sampling))
+          sampling_colorspace = "sYUV";

else? :)

@@ +389,3 @@
+  if (width != jpeg2000parse->width ||
+      height != jpeg2000parse->height ||
+      strcmp (jpeg2000parse->sampling, source_sampling) ||

and then here g_strcmp0() :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.