[Bug 767505] New: gstaudiovisualizer produces wrong timestamps with non-16 bit audio formats.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767505

            Bug ID: 767505
           Summary: gstaudiovisualizer produces wrong timestamps with
                    non-16 bit audio formats.
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: thomas.jones at utoronto.ca
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 329581
  --> https://bugzilla.gnome.org/attachment.cgi?id=329581&action=edit
Patch that should fix the problem

gstaudiovisualizer computes a number of bytes from a number of samples like
this:

sbpf = scope->req_spf * channels * sizeof (gint16);

This fails for obvious reasons if the actual audio data isn't 2 bytes per
sample, fortunately GstAudioInfo has exactly the information we need to do this
calculation correctly.

sbpf = scope->req_spf * GST_AUDIO_INFO_BPF (&scope->ainfo);

This issue is present in all the 1.6 visualizer's too but it didn't matter
because the concrete classes that used it all only took 16 bit audio.

Patch attached, but because my machine doesn't have GStreamer 1.8 and I don't
really want to go through setting up a sandbox for this I haven't tested it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.