[Bug 767505] audiovisualizer: produces wrong timestamps with non-16 bit audio formats

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767505

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329581|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329581:
 --> (https://bugzilla.gnome.org/review?bug=767505&attachment=329581)

Seems mostly correct, but can you update the patch so it actually compiles?
Thanks :)

::: gst-libs/gst/pbutils/gstaudiovisualizer.c
@@ +1060,3 @@
   rate = GST_AUDIO_INFO_RATE (&scope->ainfo);
   bps = GST_AUDIO_INFO_BPS (&scope->ainfo);
+  bytes_per_samp = GST_AUDIO_INFO_BPF (&scope->ainfo);

Let's call it bpf maybe? :)

@@ +1073,2 @@
   /* this is what we want */
+  sbpf = scope->req_spf bytes_per_samp;

This doesn't compile, you're missing the *

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.